Add the rest of the options to the security hash for the rundeck config. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig. Updated tests.
|
I was unable to complete the integration test as suggested in the docs, I tried several different VMs, different versions of puppet, and even specifying different versions of puppetlabs-java but the tests always failed when trying to install Java onto the VM. |
|
Hi @jasonschwab, thansk for this PR. Travis executed your tests and is happy about it, this is enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the template for the rundeck config accepts params for the following:
rundeck.security.useHMacRequestTokensrundeck.security.apiCookieAccess.enabledAdded the rest of the options to the security hash for the rundeck config.
Added to support the following:
rundeck.api.tokens.duration.maxrundeck.security.csrf.referer.filterMethodrundeck.security.csrf.referer.allowApirundeck.security.csrf.referer.requireHttpsUpdated tests to cover the conditionals in the template.